fix: spec.preserveUnknownFields must be set to false to allow upgrades from v1beta1 #709
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from v1beta1 Signed-off-by: Jack Andersen <[email protected]>
jessesuen
approved these changes
May 5, 2021
oliverbaehler
added a commit
that referenced
this pull request
May 11, 2021
#713) * add context variable for templating purpose Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * update version of argocd-notification chart Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * fix: spec.preserveUnknownFields must be set to false to allow upgrades from v1beta1 (#709) Signed-off-by: Jack Andersen <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * feat: add resources to argo-rollouts deployment (#711) - add destinationrule to clusterrolebinding Signed-off-by: Hui Kang <[email protected]> Co-authored-by: Hui Kang <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * chore(argo-events): update argo-events to 1.3.3 (#720) Signed-off-by: Alec Rajeev <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * chore(argo-cd): upgrade redis-ha version to 4.12.14 (#710) Signed-off-by: Aniek Gul <[email protected]> Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * Update charts/argocd-notifications/Chart.yaml Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * Update charts/argocd-notifications/templates/configmap.yaml Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> Co-authored-by: Sergiy Gavrylenko <[email protected]> Co-authored-by: jandersen-plaid <[email protected]> Co-authored-by: cskh <[email protected]> Co-authored-by: Hui Kang <[email protected]> Co-authored-by: Alec Rajeev <[email protected]> Co-authored-by: aniekgul <[email protected]> Co-authored-by: Oliver Bähler <[email protected]>
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
…s from v1beta1 (argoproj#709) Signed-off-by: Jack Andersen <[email protected]>
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
argoproj#713) * add context variable for templating purpose Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * update version of argocd-notification chart Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * fix: spec.preserveUnknownFields must be set to false to allow upgrades from v1beta1 (argoproj#709) Signed-off-by: Jack Andersen <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * feat: add resources to argo-rollouts deployment (argoproj#711) - add destinationrule to clusterrolebinding Signed-off-by: Hui Kang <[email protected]> Co-authored-by: Hui Kang <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * chore(argo-events): update argo-events to 1.3.3 (argoproj#720) Signed-off-by: Alec Rajeev <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * chore(argo-cd): upgrade redis-ha version to 4.12.14 (argoproj#710) Signed-off-by: Aniek Gul <[email protected]> Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * Update charts/argocd-notifications/Chart.yaml Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * Update charts/argocd-notifications/templates/configmap.yaml Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> Co-authored-by: Sergiy Gavrylenko <[email protected]> Co-authored-by: jandersen-plaid <[email protected]> Co-authored-by: cskh <[email protected]> Co-authored-by: Hui Kang <[email protected]> Co-authored-by: Alec Rajeev <[email protected]> Co-authored-by: aniekgul <[email protected]> Co-authored-by: Oliver Bähler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows argoproj/argo-rollouts#1069 and fixes #604
This is just following along from prior work in the argo-rollouts repository to ensure that upgrades can happen between prior CRD API versions.
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.